Replace angular-cli patch with something less risky #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezonant
changed the title
|
Actually this is failing for final production build of the client for me. |
rezonant
changed the title
|
I was on the wrong branch :-S -- The production build succeeds with this solution. |
|
did a video upload/playback test and things look to be working. all polyfills in this PR are the ones used by webpack: |
|
Thanks @rezonant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it sounds, this replaces the super-hairy angular patch that Peertube has now with something that doesn't need to modify any external modules.
It uses Typescript's path resolution settings available in
tsconfig.json'spathssection. UsingpathsI remap all of the modules that are not available on the web. Changeset includes a trivialglobalpolyfill and the polyfills PeerTube depends on.All polyfills brought in with this PR are the ones Webpack uses:
https://github.com/webpack/node-libs-browser#readme
Status: In testing. A video upload and playback smoke test looks good.